• src/syncterm/telnets.c

    From Deucе@VERT to Git commit to main/sbbs/master on Tue Dec 31 02:42:03 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/bb2c3ece7860d6d3e68e10c7
    Modified Files:
    src/syncterm/telnets.c
    Log Message:
    Whoops, close that #ifdef

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Deucе@VERT to Git commit to main/sbbs/master on Tue Dec 31 10:32:19 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/4966f43090eb13aa746bb9f1
    Modified Files:
    src/syncterm/telnets.c
    Log Message:
    C17 deprecated ATOMIC_INIT_VAR() so we can use regular initialization

    Since even Microsoft (experimentally) claims to support C17 atomics
    correctly, don't bother with the extra verbosity of using explicit
    atomic "stuff" and just use assigment/access as normal.

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Deucе@VERT to Git commit to main/sbbs/master on Fri Jan 17 07:25:15 2025
    https://gitlab.synchro.net/main/sbbs/-/commit/ad3236e3205dc25b9c3e3631
    Modified Files:
    src/syncterm/telnets.c
    Log Message:
    Set initial telnet modes in telnets

    Not sure how I missed this one.

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Deucе@VERT to Git commit to main/sbbs/master on Sun Mar 15 01:06:05 2026
    https://gitlab.synchro.net/main/sbbs/-/commit/94c6ca35bbbfa4e4051b6e29
    Modified Files:
    src/syncterm/telnets.c
    Log Message:
    Add missing NULL checks on malloc() in telnets_connect()

    Same issue as ssh.c: conn_api.rd_buf and conn_api.wr_buf were
    allocated without NULL checks. The I/O threads would dereference
    NULL and crash on allocation failure.

    Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Deucе@VERT to Git commit to main/sbbs/master on Sun Mar 15 14:09:13 2026
    https://gitlab.synchro.net/main/sbbs/-/commit/b97d08c93795dc03cc1f2ac7
    Modified Files:
    src/syncterm/telnets.c
    Log Message:
    Fix infinite loop and missing error checks in telnets.c

    - Input thread: change drain loop condition from "buffered < rd" to
    "bufsz > 0", and add !conn_api.terminate guard. The old condition
    compared against the last read size instead of remaining data,
    causing an infinite loop once bufsz drained to zero.
    - Add missing NULL checks on create_conn_buf() return values in
    telnets_connect(), matching all other connection providers.

    Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net