Forum: Too Lazy BBS

Who's Online
Recent Visitors
- Nightfox
  Sat Nov 23 16:45:22 2024
  from Beaverton, Or via Telnet
- Rixter
  Sat Nov 23 10:41:20 2024
  from Madison, Nc via SSH
- Amr
  Fri Nov 22 07:50:22 2024
  from Fayetteville, Nc via Telnet
- Mike Dippel
  Fri Nov 22 00:19:24 2024
  from Sun City Center, Fl via Telnet

System Info

Sysop:	Amessyroom
Location:	Fayetteville, NC
Users:	39
Nodes:	6 (0 / 6)
Uptime:	12:38:36
Calls:	175
Calls today:	2
Files:	118
Messages:	64,081

DDMsgReader: When listing messages via lightbar, check if the subject

From Rob Swindell@VERT to GitLab note in main/sbbs on Sun Jun 30 13:14:59 2024

https://gitlab.synchro.net/main/sbbs/-/merge_requests/442#note_5390

I suspect with this change, textIsUTF8 will *always* be `true`. Are you actually seeing messages with subjects that are *not* valid UTF-8?

All ASCII strings are valid UTF-8, while not all UTF-8 strings are valid ASCII.

You probably mean to write something more like this:
```
str_is_ascii(str) === false && str_is_utf8(str) === true
```

---
■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net

From Eric Oulashin@VERT to GitLab note in main/sbbs on Sun Jun 30 14:01:45 2024

https://gitlab.synchro.net/main/sbbs/-/merge_requests/442#note_5392

Logically that makes sense, though it has the same effect in the message list either way. I've updated it to check this way and pushed my changes, and ran another build pipeline.

---
■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net