• Aborting message scan for text now does something weird in v3.21

    From Rob Swindell@1:103/705 to GitLab issue in main/sbbs on Mon May 5 23:37:33 2025
    open https://gitlab.synchro.net/main/sbbs/-/issues/926

    When hitting Ctrl-C during scan messages for text lands the user at the "Reading" prompt, but only when answering "No" to the Subjects Only prompt:

    ```
    ■ Main ■ 0:08:42 [4] fsxNet [7] FSX Ads: F

    find yo text son

    Sub-board: FSX Ads, Group: fsxNet, or All: A

    [√] Display Subjects Only? No

    Text to search for: LAJDSF

    Main Sysop Notices 111 Main General 500 (Ctrl-C hit here)
    ■ Reading ■ Main General (?=Menu) (69 of 500):
    ```

    This doesn't happen in v3.20.
    --- SBBSecho 3.25-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to GitLab note in main/sbbs on Thu May 8 18:19:48 2025
    https://gitlab.synchro.net/main/sbbs/-/issues/926#note_7213

    I've traced this down to the addition of "clearabort()" to sbbs_t::getkey(): ```
    +++ b/src/sbbs3/getkey.cpp
    @@ -42,7 +42,7 @@ char sbbs_t::getkey(int mode)
    YIELD(); // just in case someone is looping on getkey() when they shouldn't
    return 0;
    }
    - clearabort();
    +// clearabort();
    if ((sys_status & SS_USERON || action == NODE_DFLT) && !(mode & (K_GETSTR | K_NOSPIN)))
    mode |= (useron.misc & SPIN);
    term->lncntr = 0;
    ```

    By removing this call, hitting Ctrl-C during a scan for message text works *more* like it did in v3.20, but not exactly: the "Reading" prompt is redisplayed before the actual abortion of the scan. For example:
    ```
    ■ Main ■ 0:00:04 [2] DOVE-Net [1] General: F

    find yo text son

    Sub-board: General, Group: DOVE-Net, or All: A

    [√] Display Subjects Only? No

    Text to search for: ALSJKDF

    Main Sysop Notices 111 Main General 500 ■ Reading ■ Main General (?=Menu) (348 of 500):

    Message Scan aborted.

    ■ Main ■ 0:00:08 [2] DOVE-Net [1] General:
    ```

    In v3.20, that "Reading" prompt would not be redisplayed.

    I'm not sure why all the additions of clearabort() calls (in the Terminal Abstraction branch) to the input functions, but they appear to be causing issues with Ctrl-C behavior.
    --- SBBSecho 3.25-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to GitLab note in main/sbbs on Fri May 9 10:42:09 2025
    https://gitlab.synchro.net/main/sbbs/-/issues/926#note_7223

    Removing that call to clearabort() isn't acceptable either as that causes a message scan to abort when a single message is aborted (e.g. hitting 'N' at the pause prompt of a multiple-page message).
    --- SBBSecho 3.25-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to GitLab note in main/sbbs on Tue May 13 19:39:18 2025
    https://gitlab.synchro.net/main/sbbs/-/issues/926#note_7237

    Correction: I was able to reproduce this eventually on v3.20, so it's not a "new" bug.
    --- SBBSecho 3.26-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to GitLab issue in main/sbbs on Tue May 13 19:56:35 2025
    close https://gitlab.synchro.net/main/sbbs/-/issues/926
    --- SBBSecho 3.26-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)