• [bug][rslight] disabled menu.conf entries cause blank HTML linksoutput in page header

    From Byrl Raze Buckbriar@news0@octade.net to rocksolid.nodes.help on Wed Oct 16 20:15:47 2024
    From Newsgroup: rocksolid.nodes.help

    --Signature=_Wed__16_Oct_2024_15_15_43_-0500_5qfqVRbF=6W/.Oj=
    Content-Type: text/plain; charset=US-ASCII
    Content-Disposition: inline
    Content-Transfer-Encoding: quoted-printable

    [bug][rslight] disabled menu.conf entries cause blank HTML links output in = page header

    config/menu.conf looks like this:

    ```
    # Add your sections below:
    rocksolid:1:1
    USENET:1:1
    NEWS:1:1
    :BLUEWORLDHOSTING:1:1
    :MIXMIN:1:1
    ```

    The two tail entries are disabled using the leading colon character.

    Although disabled, Rocksolid Light still outputs blank html table cells and=
    hyperlinks in the header button bar for those disabled entries. The pasted=
    code here demonstrates:

    ```
    <p align=3D"center" class=3D"np_header_button_bar">
    <table cellpadding=3D"0" cellspacing=3D"0">
    <tbody>


    <form target=3D"_self" action=3D"../rocksolid">
    <button class=3D"np_header_button_link" type=3D"submit">
    rocksolid</button>
    </form>
    </td>

    <form target=3D"_self" action=3D"../USENET">
    <button class=3D"np_header_button_link" type=3D"submit">
    USENET</button>
    </form>
    </td>

    <form target=3D"_self" action=3D"../NEWS">
    <button class=3D"np_header_button_link" type=3D"submit">
    NEWS</button>
    </form>
    </td>
    #### DISABLED ENTRY CODE ####

    <form target=3D"_self" action=3D"../">
    <button class=3D"np_header_button_link" type=3D"submit">
    </button>
    </form>
    </td>
    #### DISABLED ENTRY CODE ####

    <form target=3D"_self" action=3D"../">
    <button class=3D"np_header_button_link" type=3D"submit">
    </button>
    </form>
    </td>
    </tr>
    </tbody>
    </table>

    ```

    In some themes these blank links in the header bar are not visible because =
    of the lack of text. But they still take up screen real estate and are clic= kable links. If theme colors are changed to create border or background col=
    or the elements become visible and break visual appearance.

    If I add more colon-disabled entries then one new table cell and link is ou= tput for each such entry.

    Expected behavior is for the engine to skip disabled entries so they have n=
    o effect on the generated page source.

    --=20
    Byrl Raze Buckbriar . OCTADE . < https://octade.net >
    Hacker Hotline . voice & SMS . (781) OCT-AGON
    KeyOxide . < https://keyoxide.org/keyoxide0@octade.net >

    --Signature=_Wed__16_Oct_2024_15_15_43_-0500_5qfqVRbF=6W/.Oj=
    Content-Type: application/pgp-signature

    -----BEGIN PGP SIGNATURE-----

    iHUEARYIAB0WIQRneuMjkp+P7n1uq4moad1ZYOZmFwUCZxAe7wAKCRCoad1ZYOZm F5OVAP9E+Hln1jYzUNU0LHNeHDjL/s/kzRx5onmHbJtr01T5+AEAvSCEJ9KgLPzN t4Ql7efu2VDjWkkvPyLCwYDlp1WUUA0=
    =dKHO
    -----END PGP SIGNATURE-----

    --Signature=_Wed__16_Oct_2024_15_15_43_-0500_5qfqVRbF=6W/.Oj=--
    --- Synchronet 3.21a-Linux NewsLink 1.2
  • From Retro Guy@retroguy@novabbs.com to rocksolid.nodes.help on Wed Oct 16 13:24:40 2024
    From Newsgroup: rocksolid.nodes.help

    On Wed, 16 Oct 2024 20:15:47 +0000, Byrl Raze Buckbriar wrote:

    [bug][rslight] disabled menu.conf entries cause blank HTML links output in page header

    config/menu.conf looks like this:

    ```
    # Add your sections below:
    rocksolid:1:1
    USENET:1:1
    NEWS:1:1
    :BLUEWORLDHOSTING:1:1
    :MIXMIN:1:1
    ```

    The two tail entries are disabled using the leading colon character.

    Although disabled, Rocksolid Light still outputs blank html table cells and hyperlinks in the header button bar for those disabled entries. The pasted code here demonstrates:

    ```
    <p align="center" class="np_header_button_bar">
    <table cellpadding="0" cellspacing="0">
    <tbody>


    <form target="_self" action="../rocksolid">
    <button class="np_header_button_link" type="submit">
    rocksolid</button>
    </form>
    </td>

    <form target="_self" action="../USENET">
    <button class="np_header_button_link" type="submit">
    USENET</button>
    </form>
    </td>

    <form target="_self" action="../NEWS">
    <button class="np_header_button_link" type="submit">
    NEWS</button>
    </form>
    </td>
    #### DISABLED ENTRY CODE ####

    <form target="_self" action="../">
    <button class="np_header_button_link" type="submit">
    </button>
    </form>
    </td>
    #### DISABLED ENTRY CODE ####

    <form target="_self" action="../">
    <button class="np_header_button_link" type="submit">
    </button>
    </form>
    </td>
    </tr>
    </tbody>
    </table>

    ```

    In some themes these blank links in the header bar are not visible because of the lack of text. But they still take up screen real estate and are clickable links. If theme colors are changed to create border or background color the elements become visible and break visual appearance.

    If I add more colon-disabled entries then one new table cell and link is output for each such entry.

    Expected behavior is for the engine to skip disabled entries so they have no effect on the generated page source.

    This has been fixed, but it's in devel. I only noticed that a couple of
    days ago.
    --- Synchronet 3.21a-Linux NewsLink 1.2
  • From Retro Guy@retroguy@novabbs.com to rocksolid.nodes.help on Wed Oct 16 23:06:00 2024
    From Newsgroup: rocksolid.nodes.help

    On Wed, 16 Oct 2024 20:24:40 +0000, Retro Guy wrote:

    On Wed, 16 Oct 2024 20:15:47 +0000, Byrl Raze Buckbriar wrote:

    [bug][rslight] disabled menu.conf entries cause blank HTML links output
    in page header

    config/menu.conf looks like this:

    ```
    # Add your sections below:
    rocksolid:1:1
    USENET:1:1
    NEWS:1:1
    :BLUEWORLDHOSTING:1:1
    :MIXMIN:1:1
    ```
    <snip>
    In some themes these blank links in the header bar are not visible
    because of the lack of text. But they still take up screen real estate
    and are clickable links. If theme colors are changed to create border or
    background color the elements become visible and break visual
    appearance.

    If I add more colon-disabled entries then one new table cell and link is
    output for each such entry.

    Expected behavior is for the engine to skip disabled entries so they
    have no effect on the generated page source.

    This has been fixed, but it's in devel. I only noticed that a couple of
    days ago.

    devel has now been merged into master and pushed to gitlab.
    --
    Retro Guy
    --- Synchronet 3.21a-Linux NewsLink 1.2
  • From Byrl Raze Buckbriar@news0@octade.net to rocksolid.nodes.help on Thu Oct 17 03:28:44 2024
    From Newsgroup: rocksolid.nodes.help

    --Signature=_Wed__16_Oct_2024_22_28_43_-0500__g/3=iFXpUbEPCz2
    Content-Type: text/plain; charset=US-ASCII
    Content-Disposition: inline
    Content-Transfer-Encoding: quoted-printable

    On Wed, 16 Oct 2024 23:06:00 +0000
    Retro Guy <retroguy@novabbs.com> wrote:

    On Wed, 16 Oct 2024 20:24:40 +0000, Retro Guy wrote:
    =20
    On Wed, 16 Oct 2024 20:15:47 +0000, Byrl Raze Buckbriar wrote:

    [bug][rslight] disabled menu.conf entries cause blank HTML links output
    in page header

    config/menu.conf looks like this:

    ```
    # Add your sections below:
    rocksolid:1:1
    USENET:1:1
    NEWS:1:1
    :BLUEWORLDHOSTING:1:1
    :MIXMIN:1:1
    ```
    <snip>
    In some themes these blank links in the header bar are not visible
    because of the lack of text. But they still take up screen real estate
    and are clickable links. If theme colors are changed to create border =
    or
    background color the elements become visible and break visual
    appearance.

    If I add more colon-disabled entries then one new table cell and link =
    is
    output for each such entry.

    Expected behavior is for the engine to skip disabled entries so they
    have no effect on the generated page source.

    This has been fixed, but it's in devel. I only noticed that a couple of days ago.
    =20
    devel has now been merged into master and pushed to gitlab.
    =20
    --=20
    Retro Guy

    I pulled master from gitlab and upgraded. Then I ran cron. The extrad code = generation still persists.

    I rebooted and tried again. The extra code still persists.

    I upgraded to rocksolid light 0.9.159.

    If I prefix the lines with a hashtag the extraneous code is no longer produ= ced in the web pages. If I remove the lines the bug is also resolved. But i=
    f I prefix them with a colon it stays the same. I assumed that menu.conf us=
    es the same prefix syntax as groups.txt. Was my assumption wrong?

    --=20
    Byrl Raze Buckbriar . OCTADE . < https://octade.net >
    Hacker Hotline . voice & SMS . (781) OCT-AGON
    KeyOxide . < https://keyoxide.org/keyoxide0@octade.net >

    --Signature=_Wed__16_Oct_2024_22_28_43_-0500__g/3=iFXpUbEPCz2
    Content-Type: application/pgp-signature

    -----BEGIN PGP SIGNATURE-----

    iHUEARYIAB0WIQRneuMjkp+P7n1uq4moad1ZYOZmFwUCZxCEawAKCRCoad1ZYOZm F0TKAP48SwPzwp4EnjWjWzCS2K7oVMn/ZPX7WRF+Q34J7njhQAEA9ZpDSnSQZuiv sUQxMGzd8Efn0dn0rXnmJgZKWC69IQk=
    =79Hv
    -----END PGP SIGNATURE-----

    --Signature=_Wed__16_Oct_2024_22_28_43_-0500__g/3=iFXpUbEPCz2--
    --- Synchronet 3.21a-Linux NewsLink 1.2
  • From Retro Guy@retroguy@novabbs.com to rocksolid.nodes.help on Thu Oct 17 09:28:27 2024
    From Newsgroup: rocksolid.nodes.help

    On Thu, 17 Oct 2024 3:28:44 +0000, Byrl Raze Buckbriar wrote:

    On Wed, 16 Oct 2024 23:06:00 +0000
    Retro Guy <retroguy@novabbs.com> wrote:

    On Wed, 16 Oct 2024 20:24:40 +0000, Retro Guy wrote:

    On Wed, 16 Oct 2024 20:15:47 +0000, Byrl Raze Buckbriar wrote:

    [bug][rslight] disabled menu.conf entries cause blank HTML links output >>>> in page header

    config/menu.conf looks like this:

    ```
    # Add your sections below:
    rocksolid:1:1
    USENET:1:1
    NEWS:1:1
    :BLUEWORLDHOSTING:1:1
    :MIXMIN:1:1
    ```
    <snip>
    In some themes these blank links in the header bar are not visible
    because of the lack of text. But they still take up screen real estate >>>> and are clickable links. If theme colors are changed to create border or >>>> background color the elements become visible and break visual
    appearance.

    If I add more colon-disabled entries then one new table cell and link is >>>> output for each such entry.

    Expected behavior is for the engine to skip disabled entries so they
    have no effect on the generated page source.

    This has been fixed, but it's in devel. I only noticed that a couple of
    days ago.

    devel has now been merged into master and pushed to gitlab.

    --
    Retro Guy

    I pulled master from gitlab and upgraded. Then I ran cron. The extrad
    code generation still persists.

    I rebooted and tried again. The extra code still persists.

    I upgraded to rocksolid light 0.9.159.

    If I prefix the lines with a hashtag the extraneous code is no longer produced in the web pages. If I remove the lines the bug is also
    resolved. But if I prefix them with a colon it stays the same. I assumed
    that menu.conf uses the same prefix syntax as groups.txt. Was my
    assumption wrong?

    Ah, I see now what you mean. I'm not so smart lol.

    Anyway, the bug I had fixed was causing exactly the problem you mention
    if there was a blank line in menu.conf. I see now that you mean starting
    with a colon.

    The colon in groups.txt is how Newsportal read that file. The ':Groups
    Title' was how it displayed a header on a page, which RSLight does not
    do, but the colon remains.

    menu.conf does not recognize a colon as the start of a line to ignore.
    TO remove a section from the menu you would do this:

    # Add your sections below:
    rocksolid:1:1
    USENET:1:1
    NEWS:1:1
    BLUEWORLDHOSTING:0:1
    MIXMIN:0:1

    To completely remove them use '#' at the start of the line.

    I hope that is what was your goal and that I understand correctly. If
    not, let me know and I'll try harder :)
    --
    Retro Guy
    --- Synchronet 3.21a-Linux NewsLink 1.2
  • From Retro Guy@retroguy@novabbs.com to rocksolid.nodes.help on Thu Oct 17 11:31:40 2024
    From Newsgroup: rocksolid.nodes.help

    On Thu, 17 Oct 2024 9:28:27 +0000, Retro Guy wrote:

    On Thu, 17 Oct 2024 3:28:44 +0000, Byrl Raze Buckbriar wrote:

    On Wed, 16 Oct 2024 23:06:00 +0000
    Retro Guy <retroguy@novabbs.com> wrote:

    On Wed, 16 Oct 2024 20:24:40 +0000, Retro Guy wrote:

    On Wed, 16 Oct 2024 20:15:47 +0000, Byrl Raze Buckbriar wrote:

    [bug][rslight] disabled menu.conf entries cause blank HTML links output >>>>> in page header

    config/menu.conf looks like this:

    ```
    # Add your sections below:
    rocksolid:1:1
    USENET:1:1
    NEWS:1:1
    :BLUEWORLDHOSTING:1:1
    :MIXMIN:1:1
    ```
    <snip>
    In some themes these blank links in the header bar are not visible
    because of the lack of text. But they still take up screen real estate >>>>> and are clickable links. If theme colors are changed to create border or >>>>> background color the elements become visible and break visual
    appearance.

    If I add more colon-disabled entries then one new table cell and link is >>>>> output for each such entry.

    Expected behavior is for the engine to skip disabled entries so they >>>>> have no effect on the generated page source.

    This has been fixed, but it's in devel. I only noticed that a couple of >>>> days ago.

    devel has now been merged into master and pushed to gitlab.

    --
    Retro Guy

    I pulled master from gitlab and upgraded. Then I ran cron. The extrad
    code generation still persists.

    I rebooted and tried again. The extra code still persists.

    I upgraded to rocksolid light 0.9.159.

    If I prefix the lines with a hashtag the extraneous code is no longer
    produced in the web pages. If I remove the lines the bug is also
    resolved. But if I prefix them with a colon it stays the same. I assumed
    that menu.conf uses the same prefix syntax as groups.txt. Was my
    assumption wrong?

    Ah, I see now what you mean. I'm not so smart lol.

    Anyway, the bug I had fixed was causing exactly the problem you mention
    if there was a blank line in menu.conf. I see now that you mean starting
    with a colon.

    The colon in groups.txt is how Newsportal read that file. The ':Groups
    Title' was how it displayed a header on a page, which RSLight does not
    do, but the colon remains.

    menu.conf does not recognize a colon as the start of a line to ignore.
    TO remove a section from the menu you would do this:

    # Add your sections below:
    rocksolid:1:1
    USENET:1:1
    NEWS:1:1
    BLUEWORLDHOSTING:0:1
    MIXMIN:0:1

    To completely remove them use '#' at the start of the line.

    I hope that is what was your goal and that I understand correctly. If
    not, let me know and I'll try harder :)

    I'm now reading menu.conf in only one function, and checking that the
    line starts with an alphanumeric. If it is blank, starts with '#' or
    anything else non-alphanumeric, the line is ignored.

    This file is read in a lot of scripts, so I want to test it for a day or
    so to make sure I didn't break anything. Once done, it'll be easy to
    modify just being in one function.
    --
    Retro Guy
    --- Synchronet 3.21a-Linux NewsLink 1.2
  • From Retro Guy@retroguy@novabbs.com to rocksolid.nodes.help on Thu Oct 17 11:49:34 2024
    From Newsgroup: rocksolid.nodes.help

    On Thu, 17 Oct 2024 11:31:40 +0000, Retro Guy wrote:

    On Thu, 17 Oct 2024 9:28:27 +0000, Retro Guy wrote:

    On Thu, 17 Oct 2024 3:28:44 +0000, Byrl Raze Buckbriar wrote:

    On Wed, 16 Oct 2024 23:06:00 +0000
    Retro Guy <retroguy@novabbs.com> wrote:

    On Wed, 16 Oct 2024 20:24:40 +0000, Retro Guy wrote:

    On Wed, 16 Oct 2024 20:15:47 +0000, Byrl Raze Buckbriar wrote:

    [bug][rslight] disabled menu.conf entries cause blank HTML links output >>>>>> in page header

    config/menu.conf looks like this:

    ```
    # Add your sections below:
    rocksolid:1:1
    USENET:1:1
    NEWS:1:1
    :BLUEWORLDHOSTING:1:1
    :MIXMIN:1:1
    ```
    <snip>
    In some themes these blank links in the header bar are not visible >>>>>> because of the lack of text. But they still take up screen real estate >>>>>> and are clickable links. If theme colors are changed to create border or >>>>>> background color the elements become visible and break visual
    appearance.

    If I add more colon-disabled entries then one new table cell and link is >>>>>> output for each such entry.

    Expected behavior is for the engine to skip disabled entries so they >>>>>> have no effect on the generated page source.

    This has been fixed, but it's in devel. I only noticed that a couple of >>>>> days ago.

    devel has now been merged into master and pushed to gitlab.

    --
    Retro Guy

    I pulled master from gitlab and upgraded. Then I ran cron. The extrad
    code generation still persists.

    I rebooted and tried again. The extra code still persists.

    I upgraded to rocksolid light 0.9.159.

    If I prefix the lines with a hashtag the extraneous code is no longer
    produced in the web pages. If I remove the lines the bug is also
    resolved. But if I prefix them with a colon it stays the same. I assumed >>> that menu.conf uses the same prefix syntax as groups.txt. Was my
    assumption wrong?

    Ah, I see now what you mean. I'm not so smart lol.

    Anyway, the bug I had fixed was causing exactly the problem you mention
    if there was a blank line in menu.conf. I see now that you mean starting
    with a colon.

    The colon in groups.txt is how Newsportal read that file. The ':Groups
    Title' was how it displayed a header on a page, which RSLight does not
    do, but the colon remains.

    menu.conf does not recognize a colon as the start of a line to ignore.
    TO remove a section from the menu you would do this:

    # Add your sections below:
    rocksolid:1:1
    USENET:1:1
    NEWS:1:1
    BLUEWORLDHOSTING:0:1
    MIXMIN:0:1

    To completely remove them use '#' at the start of the line.

    I hope that is what was your goal and that I understand correctly. If
    not, let me know and I'll try harder :)

    I'm now reading menu.conf in only one function, and checking that the
    line starts with an alphanumeric. If it is blank, starts with '#' or
    anything else non-alphanumeric, the line is ignored.

    This file is read in a lot of scripts, so I want to test it for a day or
    so to make sure I didn't break anything. Once done, it'll be easy to
    modify just being in one function.

    I'm testing this with a pretty messed up menu.conf:

    # Add your sections below:
    aus+uk:1:1

    rocksolid:1:1
    other:1:1
    :deutsch:0:1
    dupe:1:1
    usenet:1:1

    All seems to work fine. I may push this to master later today.
    --
    Retro Guy
    --- Synchronet 3.21a-Linux NewsLink 1.2
  • From Byrl Raze Buckbriar@news0@octade.net to rocksolid.nodes.help on Thu Oct 17 12:37:15 2024
    From Newsgroup: rocksolid.nodes.help

    --Signature=_Thu__17_Oct_2024_07_36_04_-0500_YelkG=m6ueNT/b5H
    Content-Type: text/plain; charset=US-ASCII
    Content-Disposition: inline
    Content-Transfer-Encoding: quoted-printable

    On Thu, 17 Oct 2024 09:28:27 +0000
    Retro Guy <retroguy@novabbs.com> wrote:

    On Thu, 17 Oct 2024 3:28:44 +0000, Byrl Raze Buckbriar wrote:
    =20
    On Wed, 16 Oct 2024 23:06:00 +0000
    Retro Guy <retroguy@novabbs.com> wrote:

    On Wed, 16 Oct 2024 20:24:40 +0000, Retro Guy wrote:

    On Wed, 16 Oct 2024 20:15:47 +0000, Byrl Raze Buckbriar wrote:

    [bug][rslight] disabled menu.conf entries cause blank HTML links out=
    put
    in page header

    config/menu.conf looks like this:

    ```
    # Add your sections below:
    rocksolid:1:1
    USENET:1:1
    NEWS:1:1
    :BLUEWORLDHOSTING:1:1
    :MIXMIN:1:1
    ```
    <snip>
    In some themes these blank links in the header bar are not visible
    because of the lack of text. But they still take up screen real esta=
    te
    and are clickable links. If theme colors are changed to create borde=
    r or
    background color the elements become visible and break visual
    appearance.

    If I add more colon-disabled entries then one new table cell and lin=
    k is
    output for each such entry.

    Expected behavior is for the engine to skip disabled entries so they >>>> have no effect on the generated page source.

    This has been fixed, but it's in devel. I only noticed that a couple =
    of
    days ago.

    devel has now been merged into master and pushed to gitlab.

    --
    Retro Guy

    I pulled master from gitlab and upgraded. Then I ran cron. The extrad
    code generation still persists.

    I rebooted and tried again. The extra code still persists.

    I upgraded to rocksolid light 0.9.159.

    If I prefix the lines with a hashtag the extraneous code is no longer produced in the web pages. If I remove the lines the bug is also
    resolved. But if I prefix them with a colon it stays the same. I assumed that menu.conf uses the same prefix syntax as groups.txt. Was my
    assumption wrong?
    =20
    Ah, I see now what you mean. I'm not so smart lol.
    =20
    Anyway, the bug I had fixed was causing exactly the problem you mention
    if there was a blank line in menu.conf. I see now that you mean starting
    with a colon.
    =20
    The colon in groups.txt is how Newsportal read that file. The ':Groups
    Title' was how it displayed a header on a page, which RSLight does not
    do, but the colon remains.
    =20
    menu.conf does not recognize a colon as the start of a line to ignore.
    TO remove a section from the menu you would do this:
    =20
    # Add your sections below:
    rocksolid:1:1
    USENET:1:1
    NEWS:1:1
    BLUEWORLDHOSTING:0:1
    MIXMIN:0:1
    =20
    To completely remove them use '#' at the start of the line.
    =20
    I hope that is what was your goal and that I understand correctly. If
    not, let me know and I'll try harder :)
    =20
    --=20
    Retro Guy

    OK, I was assuming wrongly.

    --=20
    Byrl Raze Buckbriar . OCTADE . < https://octade.net >
    Hacker Hotline . voice & SMS . (781) OCT-AGON
    KeyOxide . < https://keyoxide.org/keyoxide0@octade.net >

    --Signature=_Thu__17_Oct_2024_07_36_04_-0500_YelkG=m6ueNT/b5H
    Content-Type: application/pgp-signature

    -----BEGIN PGP SIGNATURE-----

    iHUEARYIAB0WIQRneuMjkp+P7n1uq4moad1ZYOZmFwUCZxEEtAAKCRCoad1ZYOZm F29eAQCcbScXuP2oyPu5Tdo34oUEYi459kTLIjt9sPWNCHnWgQD/bbvcUGjXs/VK OFL0d8iiQO0KSomxyD8TN/bTNdB0Yg0=
    =o9uo
    -----END PGP SIGNATURE-----

    --Signature=_Thu__17_Oct_2024_07_36_04_-0500_YelkG=m6ueNT/b5H--
    --- Synchronet 3.21a-Linux NewsLink 1.2
  • From Byrl Raze Buckbriar@news0@octade.net to rocksolid.nodes.help on Thu Oct 17 12:37:13 2024
    From Newsgroup: rocksolid.nodes.help

    --Signature=_Thu__17_Oct_2024_07_35_31_-0500_uefL.=3wT.jM7KEH
    Content-Type: text/plain; charset=US-ASCII
    Content-Disposition: inline
    Content-Transfer-Encoding: quoted-printable

    On Thu, 17 Oct 2024 11:31:40 +0000
    Retro Guy <retroguy@novabbs.com> wrote:

    On Thu, 17 Oct 2024 9:28:27 +0000, Retro Guy wrote:
    =20
    On Thu, 17 Oct 2024 3:28:44 +0000, Byrl Raze Buckbriar wrote:

    On Wed, 16 Oct 2024 23:06:00 +0000
    Retro Guy <retroguy@novabbs.com> wrote:

    On Wed, 16 Oct 2024 20:24:40 +0000, Retro Guy wrote:

    On Wed, 16 Oct 2024 20:15:47 +0000, Byrl Raze Buckbriar wrote:

    [bug][rslight] disabled menu.conf entries cause blank HTML links ou=
    tput
    in page header

    config/menu.conf looks like this:

    ```
    # Add your sections below:
    rocksolid:1:1
    USENET:1:1
    NEWS:1:1
    :BLUEWORLDHOSTING:1:1
    :MIXMIN:1:1
    ```
    <snip>
    In some themes these blank links in the header bar are not visible >>>>> because of the lack of text. But they still take up screen real est=
    ate
    and are clickable links. If theme colors are changed to create bord=
    er or
    background color the elements become visible and break visual
    appearance.

    If I add more colon-disabled entries then one new table cell and li=
    nk is
    output for each such entry.

    Expected behavior is for the engine to skip disabled entries so they >>>>> have no effect on the generated page source.

    This has been fixed, but it's in devel. I only noticed that a couple=
    of
    days ago.

    devel has now been merged into master and pushed to gitlab.

    --
    Retro Guy

    I pulled master from gitlab and upgraded. Then I ran cron. The extrad
    code generation still persists.

    I rebooted and tried again. The extra code still persists.

    I upgraded to rocksolid light 0.9.159.

    If I prefix the lines with a hashtag the extraneous code is no longer
    produced in the web pages. If I remove the lines the bug is also
    resolved. But if I prefix them with a colon it stays the same. I assum=
    ed
    that menu.conf uses the same prefix syntax as groups.txt. Was my
    assumption wrong?

    Ah, I see now what you mean. I'm not so smart lol.

    Anyway, the bug I had fixed was causing exactly the problem you mention
    if there was a blank line in menu.conf. I see now that you mean starting with a colon.

    The colon in groups.txt is how Newsportal read that file. The ':Groups Title' was how it displayed a header on a page, which RSLight does not
    do, but the colon remains.

    menu.conf does not recognize a colon as the start of a line to ignore.
    TO remove a section from the menu you would do this:

    # Add your sections below:
    rocksolid:1:1
    USENET:1:1
    NEWS:1:1
    BLUEWORLDHOSTING:0:1
    MIXMIN:0:1

    To completely remove them use '#' at the start of the line.

    I hope that is what was your goal and that I understand correctly. If
    not, let me know and I'll try harder :)
    =20
    I'm now reading menu.conf in only one function, and checking that the
    line starts with an alphanumeric. If it is blank, starts with '#' or
    anything else non-alphanumeric, the line is ignored.
    =20
    This file is read in a lot of scripts, so I want to test it for a day or
    so to make sure I didn't break anything. Once done, it'll be easy to
    modify just being in one function.
    =20
    --=20
    Retro Guy

    Somewhere in the bowels of the darknet, some 31337 haXor has been running a=
    rslight server with 30 section names beginning with odd punctuation charac= ters. When he upgrades and notices something is off he will be so frustrate=
    d that he sets an autodialer to call psychiatric hotlines for three days st= raight. Then he will throw his server down a well after which he will join =
    a monastery where computers are forbidden.

    You just may have saved his soul!

    --=20
    Byrl Raze Buckbriar . OCTADE . < https://octade.net >
    Hacker Hotline . voice & SMS . (781) OCT-AGON
    KeyOxide . < https://keyoxide.org/keyoxide0@octade.net >

    --Signature=_Thu__17_Oct_2024_07_35_31_-0500_uefL.=3wT.jM7KEH
    Content-Type: application/pgp-signature

    -----BEGIN PGP SIGNATURE-----

    iHUEARYIAB0WIQRneuMjkp+P7n1uq4moad1ZYOZmFwUCZxEEkwAKCRCoad1ZYOZm F2tXAPwM1qgxTFZCJJKx9vsLjJf3+QWZFArn96TxFHRMI8AQKAEA2BeJ17rTwphN EBmuH+ja9MeEie6namzHDmo1LgaJfgU=
    =WHvv
    -----END PGP SIGNATURE-----

    --Signature=_Thu__17_Oct_2024_07_35_31_-0500_uefL.=3wT.jM7KEH--
    --- Synchronet 3.21a-Linux NewsLink 1.2