Sysop: | Amessyroom |
---|---|
Location: | Fayetteville, NC |
Users: | 28 |
Nodes: | 6 (0 / 6) |
Uptime: | 53:45:51 |
Calls: | 422 |
Files: | 1,025 |
Messages: | 90,610 |
On Wed, Mar 19, 2025 at 06:18:49PM +0100, Ulrich Müller wrote:
There was a discussion in #gentoo-pms if we should drop the "domo"
install function in EAPI 9:
- It is not much used, only 6 packages (13 ebuilds) in the Gentoo
repository.
- Could you explain (e.g. to a new developer) what the function does,
without looking it up in the spec? :)
- The function implements rather specific functionality for a PM helper.
OTOH, the gettext domain is fixed as ${PN} which isn't always what is
needed.
Rather than fixing the problem mentioned in the last item, it may be
better to reimplement the function in an eclass, where it could also support different domains.
Notes:
- "domo" already existed in early Portage versions. [1]
- Bug 951502 [2] has been filed for the (conceivable) EAPI 9 feature.
Comments?
[1] https://github.com/gentoo/gentoo-historical-2/commits/e1fb2ea89f665be4f89bc7980a8a26cf349d3972/sys-apps/portage/files/ebuild
[2] https://bugs.gentoo.org/951502
Just to say that I agree that we do not need it, I've (personally) only
used domo *once* in games-strategy/tornado after somewhat randomly
noticing that the helper existed (formerly that ebuild did a plocale_for_each_locale ... insinto [...]/$1/LC_MESSAGES).
Arguably the very low usage hardly even needs a ebuild helper too,
and that could just go back to the foreach (or maybe some better way,
been 3-4 years since I looked at that package so I forget the
specifics). Not to say a helper wouldn't hurt to simplify these few
ebuilds.
--
ionen
There was a discussion in #gentoo-pms if we should drop the "domo"
install function in EAPI 9:
- It is not much used, only 6 packages (13 ebuilds) in the Gentoo
repository.
- Could you explain (e.g. to a new developer) what the function does,
without looking it up in the spec? :)
- The function implements rather specific functionality for a PM helper.
OTOH, the gettext domain is fixed as ${PN} which isn't always what is
needed.
Rather than fixing the problem mentioned in the last item, it may be
better to reimplement the function in an eclass, where it could also
support different domains.
Notes:
- "domo" already existed in early Portage versions. [1]
- Bug 951502 [2] has been filed for the (conceivable) EAPI 9 feature.
Comments?
[1] https://github.com/gentoo/gentoo-historical-2/commits/e1fb2ea89f665be4f89bc7980a8a26cf349d3972/sys-apps/portage/files/ebuild
[2] https://bugs.gentoo.org/951502