Hi all,
TIDAL is a music streaming service. As I missed a TIDAL desktop app on
gentoo I created an ebuild based on
https://github.com/Mastermindzh/tidal-hifi.

It's a node js application which drove me a bit crazy. I was today years
old when I realized that the gentoo emerge sandbox is cutting network
access :)
But the node js application, as every node js app, heavily relies on dependencies, so I decided to go with the binary version.

Anyway, as I am not very firm with ebuilds it would be nice if someone
could do a review before I try to commit this ebuild to the official
portage via bugs.gentoo.org. Anyone? Thanks in advance.

https://source.devloop.de/damage/gentoo/src/branch/main/media-sound/tidal-hifi-bin

Stay healthy, everyone out there.

regards
Daniel

--- SoupGate-Win32 v1.05
* Origin: fsxNet Usenet Gateway (21:1/5)

This is an OpenPGP/MIME signed message (RFC 4880 and 3156) -----------------------2603429fae9dfe6899461afd465cd565 Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;charset=utf-8

Errata:
I have just looked up the upstream and I think the name is fine.
However I would mention somewhere that it's a third party app.
(AFAIR discord also is an electron app and 3rd party client
note that they are not official)



On Tuesday, December 24th, 2024 at 15:26, Filip Kobierski <fkobi@pm.me> wrote:

Hi Daniel,

I am no ebuild-master myself but I think I have some feedback;
- since it's a -bin package make sure to have -* in KEYWORDS
- use desktop.eclass[1]:
- domenu for the desktop file
- doicon for the icon
- also I would use dobin for installing binaries
- I would use ${PN} where possible (besides SRC_URI & HOMEPAGE

On the name though, is the -bin really nescessary if there is no
source option? On one hand we have net-im/discord but on the other
there's net-im/discord-canary-bin.
Another thing is the -hifi part. For me it implies that before
there was some non-hifi version. If that's the case than that is
fine to me.
I however would name the package tidal-desktop or just tidal.

I hope that this helps
Filip Kobierski

[1]: https://devmanual.gentoo.org/eclass-reference/desktop.eclass/

On Tuesday, December 24th, 2024 at 15:11, Daniel Buschke damage@devloop.de wrote:

Hi all,
TIDAL is a music streaming service. As I missed a TIDAL desktop app on gentoo I created an ebuild based on https://github.com/Mastermindzh/tidal-hifi.

It's a node js application which drove me a bit crazy. I was today years old when I realized that the gentoo emerge sandbox is cutting network access :)
But the node js application, as every node js app, heavily relies on dependencies, so I decided to go with the binary version.

Anyway, as I am not very firm with ebuilds it would be nice if someone could do a review before I try to commit this ebuild to the official portage via bugs.gentoo.org. Anyone? Thanks in advance.

https://source.devloop.de/damage/gentoo/src/branch/main/media-sound/tidal-hifi-bin

Stay healthy, everyone out there.

regards
Daniel

-----------------------2603429fae9dfe6899461afd465cd565--

-----BEGIN PGP SIGNATURE-----
Version: ProtonMail

wnUEARYKACcFgmdqxZgJkAUVAewu4JXrFiEEDDuAKD1tNsX0bzf/BRUB7C7g lesAAMGPAQDs8yPmwDv1GHBtw7SYxdxENxdgwIGf/ys7kWUyusjPnAEA3qkH SQV3AaqrifAlSOYAsbChtH3KnBpBTg9pxraxcwc=
=sIqC
-----END PGP SIGNATURE-----

--- SoupGate-Win32 v1.05
* Origin: fsxNet Usenet Gateway (21:1/5)

This is an OpenPGP/MIME signed message (RFC 4880 and 3156) -----------------------fa5b40fca0f843a5dd83c999d93d0ca7 Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;charset=utf-8

Hi Daniel,

I am no ebuild-master myself but I think I have some feedback;
- since it's a -bin package make sure to have -* in KEYWORDS
- use desktop.eclass[1]:
- domenu for the desktop file
- doicon for the icon
- also I would use dobin for installing binaries
- I would use ${PN} where possible (besides SRC_URI & HOMEPAGE

On the name though, is the -bin really nescessary if there is no
source option? On one hand we have net-im/discord but on the other
there's net-im/discord-canary-bin.
Another thing is the -hifi part. For me it implies that before
there was some non-hifi version. If that's the case than that is
fine to me.
I however would name the package tidal-desktop or just tidal.


I hope that this helps
Filip Kobierski

[1]: https://devmanual.gentoo.org/eclass-reference/desktop.eclass/

On Tuesday, December 24th, 2024 at 15:11, Daniel Buschke <damage@devloop.de> wrote:

Hi all,
TIDAL is a music streaming service. As I missed a TIDAL desktop app on
gentoo I created an ebuild based on https://github.com/Mastermindzh/tidal-hifi.

It's a node js application which drove me a bit crazy. I was today years
old when I realized that the gentoo emerge sandbox is cutting network
access :)
But the node js application, as every node js app, heavily relies on dependencies, so I decided to go with the binary version.

Anyway, as I am not very firm with ebuilds it would be nice if someone
could do a review before I try to commit this ebuild to the official
portage via bugs.gentoo.org. Anyone? Thanks in advance.

https://source.devloop.de/damage/gentoo/src/branch/main/media-sound/tidal-hifi-bin

Stay healthy, everyone out there.

regards
Daniel

-----------------------fa5b40fca0f843a5dd83c999d93d0ca7--

-----BEGIN PGP SIGNATURE-----
Version: ProtonMail

wnUEARYKACcFgmdqxG4JkAUVAewu4JXrFiEEDDuAKD1tNsX0bzf/BRUB7C7g lesAAHpFAQDJ1SIqljXQosQW5gNFzDN2SpR0PMJwP/tfVzLciqYhAgEA8kry FuTOcIx8mLXWIg0qDpCUNKlki91l6WPc7HXeLwk=
=xzbP
-----END PGP SIGNATURE-----

--- SoupGate-Win32 v1.05
* Origin: fsxNet Usenet Gateway (21:1/5)

On Tue, Dec 24, 2024 at 03:11:40PM +0100, Daniel Buschke wrote:

Hi all,

Hi,

thanks for your contribution!

Anyway, as I am not very firm with ebuilds it would be nice if someone could do a review before I try to commit this ebuild to the official portage via bugs.gentoo.org. Anyone? Thanks in advance.

media-sound/tidal-hifi-bin has already been packaged since last year in
the GURU overlay[1]. The linked webpage outlines how to install
packages offered in GURU and how to request access to the server to help
with development, if you're interested.

When looking to get your ebuilds reviewed, you're better off asking in
the #gentoo-dev-help channel on IRC or on the gentoo-devhelp mailing
list. Issues raised on the gentoo-dev ML generally affect a larger user
base, e.g. eclass changes, changes to global USE flags, new tools for
ebuild development.

https://source.devloop.de/damage/gentoo/src/branch/main/media-sound/tidal-hifi-bin

Stay healthy, everyone out there.

regards
Daniel

[1]: https://wiki.gentoo.org/wiki/Project:GURU

Best,
--
Lucio Sauer

-----BEGIN PGP SIGNATURE-----

iQGTBAABCgB9FiEElFlueg0TS/aEyc5qVWii3aYMopcFAmdq0ItfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDk0 NTk2RTdBMEQxMzRCRjY4NEM5Q0U2QTU1NjhBMkREQTYwQ0EyOTcACgkQVWii3aYM opcBBQgAoAgKXElD9DP5Z1u1u++jXW5VrJwqr2uuV8kLocyYSR6gWN0bgm4xT5CY F5GD54wpmcgFSOol0IzIdO5NdcefaPTNTiVeAn1U036R+dhYv0tXE9jZ/HSIlae8 7RG6CyKPUQ73WIpQ1fNXBd0Pj0hgRVDW4G+ig6fzaeA4CR2fYA1v1YXGTY12stae OExs6S0tyP1ywKa4bhLXf10iWVJb1ChZ4QyRItwbA+/Qnvi5dt8y/JZ65uFXTCXT bYRtuKzpXbie1Cvcawj1DRfA2742L0iE42rZOIqtCrGmXaSvwqf/YguS3ftusUTV 9rySQRbwVmB23bPliNrlI3w/HohPjg==
=MlP+
-----END PGP SIGNATURE-----

--- SoupGate-Win32 v1.05
* Origin: fsxNet Usenet Gateway (21:1/5)