• [gentoo-dev] [PATCH 00/16] eclass: add 'QA Notice:' prefix to eqawarn

    From Sam James@21:1/5 to All on Wed Apr 23 16:10:01 2025
    The tinderboxes won't file bugs for just bare 'eqawarn' unless the
    message has a 'QA Notice:' prefix. Add 'QA Notice:' as a prefix to
    all eqawarn calls in eclass/, with flag-o-matic.eclass and gstreamer-meson.eclass
    as exceptions as both would be quite noisy, and the gstreamer-meson.eclass checks are known to have FPs (so we don't want bugs for all of those).

    See https://bugs.gentoo.org/954151 for a motivating example.

    I'm working with toralf to keep an eye on any possibly noisy bits
    that come out of this and will watch bugs. I'd like to push this later
    today given the distutils-r1 especially means we may well be missing
    some serious issues right now.

    Sam James (16):
    distutils-r1.eclass: add 'QA Notice:' prefix to eqawarn
    python-r1.eclass: add 'QA Notice:' prefix to eqawarn
    python-utils-r1.eclass: add 'QA Notice:' prefix to eqawarn
    autotools.eclass: use 'QA Notice:' prefix in eqawarn
    cargo.eclass: use 'QA Notice:' prefix in eqawarn
    chromium-2.eclass: use 'QA Notice:' prefix in eqawarn
    cmake.eclass: use 'QA Notice:' prefix in eqawarn
    ecm.eclass: use 'QA Notice:' prefix in eqawarn
    go-module.eclass: use 'QA Notice:' prefix in eqawarn
    haskell-cabal.eclass: use 'QA Notice:' prefix in eqawarn
    java-pkg-simple.eclass: use 'QA Notice:' prefix in eqawarn
    rpm.eclass: use 'QA Notice:' prefix in eqawarn
    ruby-ng.eclass: use 'QA Notice:' prefix in eqawarn
    toolchain.eclass: use 'QA Notice:' prefix in eqawarn
    wxwidgets.eclass: use 'QA Notice:' prefix in eqawarn
    xorg-3.eclass: use 'QA Notice:' prefix in eqawarn

    eclass/autotools.eclass | 4 ++--
    eclass/cargo.eclass | 2 +-
    eclass/chromium-2.eclass | 6 +++---
    eclass/cmake.eclass | 2 +-
    eclass/distutils-r1.eclass | 10 +++++-----
    eclass/ecm.eclass | 6 +++---
    eclass/go-module.eclass | 4 ++--
    eclass/haskell-cabal.eclass | 4 ++--
    eclass/java-pkg-simple.eclass | 2 +-
    eclass/python-r1.eclass | 2 +-
    eclass/python-utils-r1.eclass | 2 +-
    eclass/rpm.eclass | 6 +++---
    eclass/ruby-ng.eclass | 2 +-
    eclass/toolchain.eclass | 2 +-
    eclass/wxwidgets.eclass | 4 ++--
    eclass/xorg-3.eclass | 2 +-
    16 files changed, 30 insertions(+), 30 deletions(-)

    --
    2.49.0

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Sam James@21:1/5 to All on Wed Apr 23 16:10:01 2025
    This makes life easier for tinderboxes, but we should improve this in some future
    EAPI.

    Signed-off-by: Sam James <sam@gentoo.org>
    ---
    eclass/cargo.eclass | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/eclass/cargo.eclass b/eclass/cargo.eclass
    index 428341d568db6..247d1bf535b96 100644
    --- a/eclass/cargo.eclass
    +++ b/eclass/cargo.eclass
    @@ -542,7 +542,7 @@ cargo_src_unpack() {
    popd >/dev/null || die

    if [[ ${#crates[@]} -ge 300 ]]; then
    - eqawarn "This package uses a very large number of CRATES. Please provide"
    + eqawarn "QA Notice: This package uses a very large number of CRATES. Please provide"
    eqawarn "a crate tarball instead and fetch it via SRC_URI. You can use"
    eqawarn "'pycargoebuild --crate-tarball' to create one."
    fi
    --
    2.49.0

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Sam James@21:1/5 to All on Wed Apr 23 16:10:01 2025
    This makes life easier for tinderboxes, but we should improve this in some future
    EAPI.

    Signed-off-by: Sam James <sam@gentoo.org>
    ---
    eclass/autotools.eclass | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    diff --git a/eclass/autotools.eclass b/eclass/autotools.eclass
    index 1545b88bc4263..bb33d251ce997 100644
    --- a/eclass/autotools.eclass
    +++ b/eclass/autotools.eclass
    @@ -598,7 +598,7 @@ autotools_run_tool() {
    done

    if [[ ${EBUILD_PHASE_FUNC} != "src_prepare" ]] ; then
    - eqawarn "Running '${1}' in ${EBUILD_PHASE_FUNC} phase"
    + eqawarn "QA Notice: Running '${1}' in ${EBUILD_PHASE_FUNC} phase"
    fi

    if ${missing_ok} && ! type -P ${1} >/dev/null ; then
    --
    2.49.0

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Sam James@21:1/5 to All on Wed Apr 23 16:10:01 2025
    This makes life easier for tinderboxes, but we should improve this in some future
    EAPI.

    Signed-off-by: Sam James <sam@gentoo.org>
    ---
    eclass/go-module.eclass | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    diff --git a/eclass/go-module.eclass b/eclass/go-module.eclass
    index 73e9ee51c7d58..14e0aad9dd2a8 100644
    --- a/eclass/go-module.eclass
    +++ b/eclass/go-module.eclass
    @@ -1,4 +1,4 @@
    -# Copyright 2019-2024 Gentoo Authors
    +# Copyright 2019-2025 Gentoo Authors
    # Distributed under the terms of the GNU General Public License v2

    # @ECLASS: go-module.eclass
    @@ -371,7 +371,7 @@ go-module_src_unpack() {
    fi
    GOFLAGS="${GOFLAGS} -p=$(makeopts_jobs)"
    if [[ "${#EGO_SUM[@]}" -gt 0 ]]; then
    - eqawarn "This ebuild uses EGO_SUM which is deprecated"
    + eqawarn "QA Notice: This ebuild uses EGO_SUM which is deprecated"
    eqawarn "Please migrate to a dependency tarball"
    eqawarn "This will become a fatal error in the future"
    _go-module_src_unpack_gosum
    --
    2.49.0

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Sam James@21:1/5 to All on Wed Apr 23 16:10:01 2025
    We need to fix this properly at some point in Portage/PMS but whatever,
    for now, add the 'QA Prefix:' prefix to eqawarn so tinderboxes pick
    these up and report them.

    Bug: https://bugs.gentoo.org/954151
    Signed-off-by: Sam James <sam@gentoo.org>
    ---
    eclass/python-r1.eclass | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/eclass/python-r1.eclass b/eclass/python-r1.eclass
    index 02d7215320a2d..7be8b5ac8d450 100644
    --- a/eclass/python-r1.eclass
    +++ b/eclass/python-r1.eclass
    @@ -620,7 +620,7 @@ python_foreach_impl() {
    [[ ! ${_DISTUTILS_CALLING_FOREACH_IMPL} &&
    ! ${_DISTUTILS_FOREACH_IMPL_WARNED} ]]
    then
    - eqawarn "python_foreach_impl has been called directly while using distutils-r1."
    + eqawarn "QA Notice: python_foreach_impl has been called directly while using distutils-r1."
    eqawarn "Please redefine python_*() phase functions to meet your expectations"
    eqawarn "instead."
    _DISTUTILS_FOREACH_IMPL_WARNED=1
    --
    2.49.0

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Sam James@21:1/5 to All on Wed Apr 23 16:10:01 2025
    This makes life easier for tinderboxes, but we should improve this in some future
    EAPI.

    Signed-off-by: Sam James <sam@gentoo.org>
    ---
    eclass/cmake.eclass | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/eclass/cmake.eclass b/eclass/cmake.eclass
    index e1bad4cbd16fe..c97f74e8a2eda 100644
    --- a/eclass/cmake.eclass
    +++ b/eclass/cmake.eclass
    @@ -303,7 +303,7 @@ _cmake_check_build_dir() {
    # TODO: For EAPI > 8, we should ban S=WORKDIR for CMake.
    # See bug #889420.
    if [[ ${S} == "${WORKDIR}" && ${BUILD_DIR} == "${WORKDIR}_build" ]] ; then
    - eqawarn "QA notice: S=WORKDIR is deprecated for cmake.eclass."
    + eqawarn "QA Notice: S=WORKDIR is deprecated for cmake.eclass."
    eqawarn "Please relocate the sources in src_unpack."
    BUILD_DIR="${WORKDIR}"/${P}_build
    fi
    --
    2.49.0

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Sam James@21:1/5 to All on Wed Apr 23 16:10:01 2025
    We need to fix this properly at some point in Portage/PMS but whatever,
    for now, add the 'QA Prefix:' prefix to eqawarn so tinderboxes pick
    these up and report them.

    Bug: https://bugs.gentoo.org/954151
    Signed-off-by: Sam James <sam@gentoo.org>
    ---
    eclass/distutils-r1.eclass | 10 +++++-----
    1 file changed, 5 insertions(+), 5 deletions(-)

    diff --git a/eclass/distutils-r1.eclass b/eclass/distutils-r1.eclass
    index 6e477823ce02d..02fe41aa388fa 100644
    --- a/eclass/distutils-r1.eclass
    +++ b/eclass/distutils-r1.eclass
    @@ -389,7 +389,7 @@ _distutils_set_globals() {
    readonly DISTUTILS_DEPS
    fi
    else
    - eqawarn "distutils-r1.eclass legacy mode is deprecated and will be removed."
    + eqawarn "QA Notice: distutils-r1.eclass legacy mode is deprecated and will be removed."
    eqawarn "Please migrate your ebuilds to use DISTUTILS_USE_PEP517 (common values"
    eqawarn "are 'setuptools' for packages using setuptools/distutils,"
    eqawarn "and 'no' for packages using non-PEP517 build systems)."
    @@ -650,7 +650,7 @@ distutils_enable_tests() {
    fi
    ;;
    setup.py)
    - eqawarn "'distutils_enable_tests setup.py' is deprecated and will be removed."
    + eqawarn "QA Notice: 'distutils_enable_tests setup.py' is deprecated and will be remo
  • From Sam James@21:1/5 to All on Wed Apr 23 16:10:01 2025
    This makes life easier for tinderboxes, but we should improve this in some future
    EAPI.

    Signed-off-by: Sam James <sam@gentoo.org>
    ---
    eclass/chromium-2.eclass | 6 +++---
    1 file changed, 3 insertions(+), 3 deletions(-)

    diff --git a/eclass/chromium-2.eclass b/eclass/chromium-2.eclass
    index 0831f1f17aa5a..e8f471e2178f4 100644
    --- a/eclass/chromium-2.eclass
    +++ b/eclass/chromium-2.eclass
    @@ -1,4 +1,4 @@
    -# Copyright 1999-2023 Gentoo Authors
    +# Copyright 1999-2025 Gentoo Authors
    # Distributed under the terms of the GNU General Public License v2

    # @ECLASS: chromium-2.eclass
    @@ -83,7 +83,7 @@ chromium_remove_language_paks() {
    # Look for missing pak files.
    for lang in ${CHROMIUM_LANGS}; do
    if [[ ! -e ${lang}.pak ]]; then
    - eqawarn "L10N warning: no .pak file for ${lang} (${lang}.pak not found)"
    + eqawarn "QA Notice: L10N warning: no .pak file for ${lang} (${lang}.pak not found)"
    fi
    done

    @@ -101,7 +101,7 @@ chromium_remove_language_paks() {
    fi

    if ! has ${lang} ${CHROMIUM_LANGS}; then
    - eqawarn "L10N warning: no ${lang} in LANGS"
    + eqawarn "QA Notice: L10N warning: no ${lang} in LANGS"
  • From Sam James@21:1/5 to All on Wed Apr 23 16:20:01 2025
    This makes life easier for tinderboxes, but we should improve this in some future
    EAPI.

    Signed-off-by: Sam James <sam@gentoo.org>
    ---
    eclass/xorg-3.eclass | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/eclass/xorg-3.eclass b/eclass/xorg-3.eclass
    index db2d8fa85df9a..4947cb86b8b02 100644
    --- a/eclass/xorg-3.eclass
    +++ b/eclass/xorg-3.eclass
    @@ -429,7 +429,7 @@ xorg-3_src_install() {

    # Many X11 libraries unconditionally install developer documentation
    if [[ -d "${D}"/usr/share/man/man3 ]]; then
    - ! in_iuse doc && eqawarn "ebuild should set XORG_DOC=doc since package installs library documentation"
    + ! in_iuse doc && eqawarn "QA Notice: ebuild should set XORG_DOC=doc since package installs library documentation"
    fi

    if in_iuse doc && ! use doc; then
    --
    2.49.0

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Sam James@21:1/5 to All on Wed Apr 23 16:20:01 2025
    This makes life easier for tinderboxes, but we should improve this in some future
    EAPI.

    Signed-off-by: Sam James <sam@gentoo.org>
    ---
    eclass/java-pkg-simple.eclass | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/eclass/java-pkg-simple.eclass b/eclass/java-pkg-simple.eclass index f3f67e7de4087..0cce6a2cdfa8f 100644
    --- a/eclass/java-pkg-simple.eclass
    +++ b/eclass/java-pkg-simple.eclass
    @@ -654,7 +654,7 @@ java-pkg-simple_src_compile() {
    JAVA_PKG_WANT_SOURCE=${tmp_source}
    JAVA_PKG_WANT_TARGET=${tmp_target}
    else
    - eqawarn "Need at least JDK 9 to compile module-info.java in src_compile."
    + eqawarn "QA Notice: Need at least JDK 9 to compile module-info.java in src_compile."
    eqawarn "Please adjust DEPEND accordingly. See https://bugs.gentoo.org/796875#c3"
    fi
    fi
    --
    2.49.0

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Sam James@21:1/5 to All on Wed Apr 23 16:20:01 2025
    This makes life easier for tinderboxes, but we should improve this in some future
    EAPI.

    Signed-off-by: Sam James <sam@gentoo.org>
    ---
    eclass/toolchain.eclass | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/eclass/toolchain.eclass b/eclass/toolchain.eclass
    index 0857395b42343..2e9350f3f5962 100644
    --- a/eclass/toolchain.eclass
    +++ b/eclass/toolchain.eclass
    @@ -1842,7 +1842,7 @@ toolchain_src_configure() {
    if [[ ${PV} == *_p* && -f "${S}"/gcc/doc/gcc.info ]] ; then
    # Safeguard against https://gcc.gnu.org/PR106899 being fixed
    # without corresponding ebuild changes.
    - eqawarn "Snapshot release with pre-generated info pages found!" + eqawarn "QA Notice: Snapshot release with pre-generated info pages found!"
    eqawarn "The BDEPEND in the ebuild should be updated to drop texinfo."
    fi

    --
    2.49.0

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Sam James@21:1/5 to All on Wed Apr 23 16:20:01 2025
    This makes life easier for tinderboxes, but we should improve this in some future
    EAPI.

    Signed-off-by: Sam James <sam@gentoo.org>
    ---
    eclass/rpm.eclass | 6 +++---
    1 file changed, 3 insertions(+), 3 deletions(-)

    diff --git a/eclass/rpm.eclass b/eclass/rpm.eclass
    index c9c21aa6ebbde..e00332e55ca0e 100644
    --- a/eclass/rpm.eclass
    +++ b/eclass/rpm.eclass
    @@ -1,4 +1,4 @@
    -# Copyright 1999-2024 Gentoo Authors
    +# Copyright 1999-2025 Gentoo Authors
    # Distributed under the terms of the GNU General Public License v2

    # @ECLASS: rpm.eclass
    @@ -31,9 +31,9 @@ rpm_unpack() {
    if [[ ${a} == ./* ]] ; then
    : # nothing to do -- path is local
    elif [[ ${a} == "${DISTDIR}"/* ]] ; then
    - eqawarn 'do not use ${DISTDIR} with rpm_unpack -- it is added for you'
    + eqawarn 'QA Notice: do not use ${DISTDIR} with rpm_unpack -- it is added for you'
    elif [[ ${a} == /* ]] ; then
    - eqawarn 'do not use full paths with rpm_unpack -- use ./ paths instead'
    + eqawarn 'QA Notice: do not use full paths with rpm_unpack -- use ./ paths instead'
    else
    a="${DISTDIR}/${a}"
    fi
    --
    2.49.0

    --- SoupGate-Win32 v1.05
    * Origi
  • From Sam James@21:1/5 to All on Wed Apr 23 16:20:01 2025
    This makes life easier for tinderboxes, but we should improve this in some future
    EAPI.

    Signed-off-by: Sam James <sam@gentoo.org>
    ---
    eclass/ruby-ng.eclass | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/eclass/ruby-ng.eclass b/eclass/ruby-ng.eclass
    index 87337dc7f1735..c7425aae434c2 100644
    --- a/eclass/ruby-ng.eclass
    +++ b/eclass/ruby-ng.eclass
    @@ -725,7 +725,7 @@ ruby-ng_rspec() {
    fi

    if [[ "${DEPEND}${BDEPEND}" != *"dev-ruby/rspec"* ]]; then
    - eqawarn "Missing test dependency dev-ruby/rspec"
    + eqawarn "QA Notice: Missing test dependency dev-ruby/rspec"
    fi

    local rspec_params=
    --
    2.49.0

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Sam James@21:1/5 to All on Wed Apr 23 16:20:01 2025
    This makes life easier for tinderboxes, but we should improve this in some future
    EAPI.

    Signed-off-by: Sam James <sam@gentoo.org>
    ---
    eclass/wxwidgets.eclass | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    diff --git a/eclass/wxwidgets.eclass b/eclass/wxwidgets.eclass
    index 0a58c44bbf408..7afea401a646d 100644
    --- a/eclass/wxwidgets.eclass
    +++ b/eclass/wxwidgets.eclass
    @@ -1,4 +1,4 @@
    -# Copyright 1999-2023 Gentoo Authors
    +# Copyright 1999-2025 Gentoo Authors
    # Distributed under the terms of the GNU General Public License v2

    # @ECLASS: wxwidgets.eclass
    @@ -69,7 +69,7 @@ setup-wxwidgets() {
    case ${WX_GTK_VER} in
    3.0-gtk3 | 3.2-gtk3) wxtoolkit=gtk3 ;;
    3.0) wxtoolkit=gtk2
    - eqawarn "This package relies on the deprecated GTK 2 slot, which will go away soon (https://bugs.gentoo.org/618642)"
    + eqawarn "QA Notice: This package relies on the deprecated GTK 2 slot, which will go away soon (https://bugs.gentoo.org/618642)"
    ;;
    esac

    --
    2.49.0

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Sam James@21:1/5 to All on Wed Apr 23 16:20:01 2025
    This makes life easier for tinderboxes, but we should improve this in some future
    EAPI.

    Signed-off-by: Sam James <sam@gentoo.org>
    ---
    eclass/haskell-cabal.eclass | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    diff --git a/eclass/haskell-cabal.eclass b/eclass/haskell-cabal.eclass
    index 7895d9256eba6..2e77bc648b165 100644
    --- a/eclass/haskell-cabal.eclass
    +++ b/eclass/haskell-cabal.eclass
    @@ -1,4 +1,4 @@
    -# Copyright 1999-2023 Gentoo Authors
    +# Copyright 1999-2025 Gentoo Authors
    # Distributed under the terms of the GNU General Public License v2

    # @ECLASS: haskell-cabal.eclass
    @@ -342,7 +342,7 @@ cabal-bootstrap() {
    elif [[ -f "${S}/Setup.hs" ]]; then
    setupmodule="${S}/Setup.hs"
    else
    - eqawarn "No Setup.lhs or Setup.hs found. Either add Setup.hs to package or call cabal-mksetup from ebuild"
    + eqawarn "QA Notice: No Setup.lhs or Setup.hs found. Either add Setup.hs to package or call cabal-mksetup from ebuild"
    cabal-mksetup
    setupmodule="${S}/Setup.hs"
    fi
    --
    2.49.0

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)