Thank you! I'll now contemplate on what to do next :)


On Sun, Oct 13, 2024 at 01:58:07PM +0100, Phil Wyett wrote:

Joost,

A fresh review.

Preamble...

Thank you for taking the time to prepare this package and your contribution to the Debian project.

The review below is for assistance. This review is offered to help package submitters to Debian mentors inorder to improve their packages prior to possible sponsorship into Debian. There is no obligation on behalf of the submitter to make any alterations based upon information provided in the review.

Review...

1. Build:

* pbuilder [1]: Good
* sbuild [2]: Good

2. Lintian [3]: Issues

Running lintian...
N:
I: caspar source: debian-watch-uses-insecure-uri http://mdcc.cx/pub/caspar/ [debian/watch:3]
N:
N: The watch file uses an unencrypted transport protocol for the URI such as
N: http:// or ftp://. It is recommended to use a secure transport such as N: HTTPS for anonymous read-only access.
N:
N: Upstream may already provide a HTTPS variant of the URI. If not, please N: contact them and ask them to consider adding one.
N:
N: Visibility: info
N: Show-Always: no
N: Check: debian/watch
N:
N:
I: caspar source: no-dh-sequencer [debian/rules]
N:
N: This package does not use the dh sequencer in debian/rules.
N:
N: While maintainers may use a variety of build systems, this one is by far N: the most popular.
N:
N: Maintainers are strongly encouraged to use the dh sequencer in new
N: packages and convert existing ones when appropriate.
N:
N: Visibility: info
N: Show-Always: no
N: Check: debian/rules/dh-sequencer
N:
N:
I: caspar source: out-of-date-standards-version 3.9.8 (released 2016-04-06) (current is 4.7.0)
N:
N: The source package refers to a Standards-Version older than the one that N: was current at the time the package was created (according to the
N: timestamp of the latest debian/changelog entry). Please consider updating
N: the package to current Policy and setting this control field
N: appropriately.
N:
N: If the package is already compliant with the current standards, you don't
N: have to re-upload the package just to adjust the Standards-Version control
N: field. However, please remember to update this field next time you upload
N: the package.
N:
N: See /usr/share/doc/debian-policy/upgrading-checklist.txt.gz in the
N: debian-policy package for a summary of changes in newer versions of
N: Policy.
N:
N: Please refer to
N: https://www.debian.org/doc/debian-policy/upgrading-checklist.html for
N: details.
N:
N: Visibility: info
N: Show-Always: no
N: Check: fields/standards-version
N:
N:
I: caspar: spare-manual-page [usr/share/man/man1/csp_helper.1.gz]
N:
N: Each manual page in /usr/share/man should have a reason to be there. This
N: manual page does not appear to have a valid reason to be shipped.
N:
N: For manual pages in sections 1 and 8, an executable (or a link to one) N: should exist. This check currently considers all installation packages N: created by the same sources, as long as they are present.
N:
N: Please refer to Manual pages (Section 12.1) in the Debian Policy Manual N: and Bug#583125 for details.
N:
N: Visibility: info
N: Show-Always: no
N: Check: documentation/manual
N: Renamed from: manpage-without-executable
N:
N:
I: caspar: typo-in-manual-page commiting committing [usr/share/man/man7/caspar.7.gz:94]
N:
N: Lintian found a spelling error in a manual page. Lintian has a list of N: common misspellings that it looks for. It does not have a dictionary like
N: a spelling checker does.
N:
N: If the string containing the spelling error is translated with the help of
N: gettext (with the help of po4a, for example) or a similar tool, please fix
N: the error in the translations as well as the English text to avoid making
N: the translations fuzzy. With gettext, for example, this means you should N: also fix the spelling mistake in the corresponding msgids in the *.po
N: files.
N:
N: Visibility: info
N: Show-Always: no
N: Check: documentation/manual
N: Renamed from: spelling-error-in-manpage
N:
N:
I: caspar source: vcs-field-uses-insecure-uri Git http://git.mdcc.cx/caspar.git/
N:
N: The Vcs-* field uses an unencrypted transport protocol for the URI. It is
N: recommended to use a secure transport such as HTTPS for anonymous
N: read-only access.
N:
N: Note that you can often just exchange e.g. git:// with https:// for
N: repositories. Though, in some cases (bzr's "lp:" or CVS's pserver) it
N: might not be possible to use an alternative url and still have a working N: (anonymous read-only) repository.
N:
N: Visibility: info
N: Show-Always: no
N: Check: fields/vcs
N:

I: Lintian run was successful.

3. Licenses [4]: Issues

philwyett@ks-tarkin:~/Development/builder/debian/mentoring/caspar-20240818$ lrc
en: Versions: recon 2.0 check 3.3.9-1

Parsing Source Tree ....
Reading d/copyright ....
Missing Files: Paragraph for debian/
Running licensecheck ....

d/copyright | licensecheck

GPL-3+ | GPL bootstrap
GPL-3+ | GPL doc/include.zmm
GPL-3+ | GPL doc/Makefile.am
GPL-3+ | GPL doc/Makefile.in
GPL-3+ | GPL Makefile.am
GPL-3+ | GPL Makefile.in
GPL-3+ | GPL setversion

I previously indicated how to correct the above.

4. Watch file [uscan --force-download]: Good

5. Build Twice [sudo pbuilder build --twice <package>.dsc]: Good

6. Reproducible builds [5]: Good

7. Install [No previous installs]: Not performed at this time.

8. Upgrade [Over previous installs if any]: Not performed at this time.

Summary...

I believe caspar is not yet ready for sponsorship at this time. Could the contributor rectify one of more of the raised issues.

Once updated to your satisfaction and a new upload done, please remove the 'moreinfo' tag on the Request For Sponsorship (RFS) bug report.

Regards

Phil

[1] pbuilder:

* Command: sudo pbuilder build <PACKAGE>.dsc
* Document: https://wiki.ubuntu.com/PbuilderHowto.
* Document: https://wiki.debian.org/PbuilderTricks

[2] sbuild:

* Command: sbuild <PACKAGE>.dsc
* Document: https://wiki.kathenas.org/pmwiki.php/Kathenas/Article00000002
* Document: https://wiki.debian.org/sbuild

[3] lintian:

* Command: lintian -v -i -I -E --pedantic --profile debian (*.dsc, *.changes, *.buildinfo). Each can throw up different results, so be thorough.
* Document: https://wiki.debian.org/Lintian

[4] lrc:

* Command: lrc
* Document: https://wiki.debian.org/CopyrightReviewTools#licenserecon

[5] reprotest

* Command: sudo reprotest --vary=-build_path,domain_host.use_sudo=1 --auto- build <PACKAGE>.dsc -- schroot unstable-amd64-sbuild
* Document: https://wiki.kathenas.org/pmwiki.php/Kathenas/Article00000004
* Document: https://wiki.debian.org/ReproducibleBuilds/
* Document: https://wiki.debian.org/ReproducibleBuilds/Howto#Newer_method

--

"I play the game for the game’s own sake"

Arthur Conan Doyle - The Adventure of the Bruce-Partington Plans

--

Buy Me A Coffee: https://buymeacoffee.com/kathenasorg

Internet Relay Chat (IRC): kathenas

Matrix: #kathenas:matrix.org

Website: https://kathenas.org

Instagram: https://instagram.com/kathenasorg/

Threads: https://www.threads.net/@kathenasorg

--

--- SoupGate-Win32 v1.05
* Origin: fsxNet Usenet Gateway (21:1/5)

Package: sponsorship-requests
Severity: normal

Hi,

My PGP key expired, I've extended it and uploaded the extended key to hkp://keyring.debian.org . However, it seems this change did not yet trickle down to our incoming machinery. I would be grateful if anybody could sponsor my latest work on my caspar package.

I am looking for a sponsor for my package "caspar":

* Package name : caspar
Version : 20240818-1
Upstream contact : Joost van Baal-Ilić <joostvb-caspar@mdcc.cx>
* URL : http://mdcc.cx/caspar/
* License : GPL-3+
* Vcs : http://git.mdcc.cx/caspar.git/
Section : devel

The source builds the following binary packages:

caspar - Makefile snippets for centralized configuration management and typesetting
caspar-doc - documentation for caspar

To access further information about this package, please visit the following URL:

https://tracker.debian.org/pkg/caspar

You can download the package with 'dget' using this command:

dget -x http://mdcc.cx/tmp/caspar/caspar_20240818-1.dsc

You can verify the integrity using my key 57930DAB0B86B067 from e.g. hkp://the.earth.li , hkp://pgp.surf.nl , hkp://keyserver.ubuntu.com or hkp://keyring.debian.org .

Changes since the last upload:

caspar (20240818-1) unstable; urgency=medium

* New upstream release - The Meždo Release
+ Upstream no longer ships typesetted (zoem) documentation in tarball
release, but build-depends upon zoem. This closes "Fails to build
binary packages again after successful build". Thanks Lucas Nussbaum.
(However, under some circumstances, dpkg-source detects local changes in
aclocal.m4 and configure. This might indicate a related bug.)
(closes: #1049637)
+ d/control: add zoem, tidy and w3m to Build-Depends.
+ d/control: s/markdown/cmark/ in Suggests.
+ d/{rules,caspar-doc.install,caspar-doc.doc-base.{caspar,
caspar-typesetting,csp_helper}}: do not try to install PostScript files:
upstream no longer generates those. BTW, one can easily generate .ps or
PDF from manpages; e.g. "man -t caspar | ps2pdf" generates Portable
Document Format on stdout.

* d/{rules,lintian-overrides}: added lintian-overrides, call dh_lintian. see
Bug#1076648: 'aephea: causes groff warning "cannot select font 'C'" [...]'
and see also https://savannah.gnu.org/bugs/index.php?64594 .

-- Joost van Baal-Ilić <joostvb@debian.org> Thu, 10 Oct 2024 12:37:38 +0200


Greetings from https://wiki.debian.org/DebianEvents/gb/2024/MiniDebConfCambridge .

Bye,

Joost

--- SoupGate-Win32 v1.05
* Origin: fsxNet Usenet Gateway (21:1/5)