XPost: linux.debian.devel.release

Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock
X-Debbugs-Cc: grml-debootstrap@packages.debian.org, team@grml.org
Control: affects -1 + src:grml-debootstrap

Please unblock package grml-debootstrap

[ Reason ]
0.121 contains three bug fixes for bugs reported directly into the
grml bug tracker, and one small feature improving systemd
integration.

We'd like them in, so installing Debian with grml-debootstrap
doesn't trigger these bugs and users using systemd with partition
autodetect should also get that to work OOTB.

[ Impact ]
The three bugs are on the scale from "quite annoying" to "unclear
impact, possibly disastrous on the upgrade from trixie to forky".
1) "Don't set bogus debconf variable on grub-cloud packages" is the
bug where we don't want to do something stupid now that might break
upgrading trixie installs to forky.
2) "fix skipping initrd creation using INITRD=no" is annoying, but
also is a trivial fix
3) "Verify that GRUB configuration points to valid block device"
is the quite annoying bug, because users discover this only after
waiting a long time for their install to complete and then abort.

[ Tests ]
We've got CI pipelines in Grml, and there is no regression. The
submitters have done tests for their patches, and I've done a manual
normal check on arm64, which went well.
One day we'll write autopkgtests, but not this cycle.

[ Risks ]
Honestly the diff is not very long and easy to understand. Also grml-debootstrap is a leaf package, so it shouldn't break other
packages in testing.

[ Checklist ]
[x] all changes are documented in the d/changelog
[x] I reviewed all changes and I approve them
[x] attach debdiff against the package in testing

[ Other info ]
Nothing I'm aware of.

Thanks!
Chris

unblock grml-debootstrap/0.121

--- SoupGate-Win32 v1.05
* Origin: fsxNet Usenet Gateway (21:1/5)

XPost: linux.debian.devel.release

Obviously I forgot to actually attach the debdiff.

Chris


diff -Nru grml-debootstrap-0.119/chroot-script grml-debootstrap-0.121/chroot-script
--- grml-debootstrap-0.119/chroot-script 2025-03-30 16:00:26.000000000 +0200
+++ grml-debootstrap-0.121/chroot-script 2025-05-14 13:20:49.000000000 +0200
@@ -576,7 +576,7 @@
KERNELVER=${KERNELIMG#/boot/vmlinuz-}

# generate initrd
- if [ -n "$INITRD" ] ; then
+ if [ "$INITRD" = "yes" ] ; then
echo "Generating initrd."
if [ "$INITRD_GENERATOR" = 'dracut' ] ; then
# shellcheck disable=SC2086
@@ -728,8 +728,8 @@
grub_device="${GRUB}"
fi

- echo "Setting grub debconf configuration for install device to $GRUB"
- if [ -n "$MAIN_GRUB_PACKAGE" ]; then
+ if [ -n "$MAIN_GRUB_PACKAGE" ] && ! [[ "$MAIN_GRUB_PACKAGE" =~ ^grub-cloud ]]; then
+ echo "Setting grub debconf configuration for install device to $GRUB"
echo "${MAIN_GRUB_PACKAGE} ${MAIN_GRUB_PACKAGE}/install_devices multiselect ${grub_device}" | debconf-set-selections
fi

diff -Nru grml-debootstrap-0.119/debian/changelog grml-debootstrap-0.121/debian/changelog
--- grml-debootstrap-0.119/de