• Bug#1091466: #1091466 unfixed; reopening

    From Daniel Leidert@21:1/5 to All on Fri Jan 3 18:40:01 2025
    --=-R7CBFqdF5RKNLHv0cM1x
    Content-Type: text/plain; charset="UTF-8"
    Content-Transfer-Encoding: quoted-printable

    Hi Thomas,

    Am Freitag, dem 03.01.2025 um 09:58 +0100 schrieb Thomas Goirand:
    On 1/1/25 19:56, Daniel Leidert wrote:

    [..]
    ilorest (5.2.0.0-4) wird eingerichtet ...
       File "/usr/lib/python3/dist- packages/ilorest/extensions/iLO_COMMANDS/EthernetCommand.py", line
    577
         ["UseNTPServers"] = True
          ^^^^^^^^^^^^^^^
    SyntaxError: cannot assign to literal
       File "/usr/lib/python3/dist- packages/ilorest/extensions/iLO_COMMANDS/EthernetCommand.py", line
    577
         ["UseNTPServers"] = True
          ^^^^^^^^^^^^^^^
    SyntaxError: cannot assign to literal
    dpkg: Fehler beim Bearbeiten des Paketes ilorest (--configure):

    Indeed, as I reverted my patch that broke things. I am currently unsure
    how to fix this one, help would be appreciated.

    I think, the original code contains a bug:

    data[eth_config_type][_path]["Oem"] [self.rdmc.app.typepath.defs.oemhp]["DHCPv4"][
    "UseNTPServers"
    ] = True

    The first and the second line get separated here and make two
    statements instead of one. And the second stament receives the warning.
    But that's not what the authors actually try to do, as shown a few
    lines below, where it says:

    data[eth_config_type][_path]["Oem"][self.rdmc.app.typepath.defs.oemhp][ "DHCPv4"
    ]["UseNTPServers"] = True

    Within the [], line continuation sets in despite the newlines, making
    this a single statement. In your patch, you basically create a similar situation by creating the single statment:

    ["UseNTPServers"] = True

    that leads to the error. I think you discovered a real bug here. A
    simple fix is attached. IMO you could also fix it by removing all
    newlines in the statement and make it a one-liner:

    data[eth_config_type][_path]["Oem"][self.rdmc.app.typepath.defs.oemhp["DHCPv4"]["UseNTPServers"] = True

    I attached a revised patch.

    Regards, Daniel


    --=-R7CBFqdF5RKNLHv0cM1x
    Content-Disposition: attachment; filename="p3.13-fix-syntax-warning.patch" Content-Type: text/x-patch; name="p3.13-fix-syntax-warning.patch"; charset="UTF-8"
    Content-Transfer-Encoding: base64

    RGVzY3JpcHRpb246IEZpeCBzeW50YXggd2FybmluZwpBdXRob3I6IFRob21hcyBHb2lyYW5kIDx6 aWdvQGRlYmlhbi5vcmc+CkJ1ZzogaHR0cHM6Ly9naXRodWIuY29tL0hld2xldHRQYWNrYXJkL3B5 dGhvbi1yZWRmaXNoLXV0aWxpdHkvaXNzdWVzLzEwNwpCdWctRGViaWFuOiBodHRwczovL2J1Z3Mu ZGViaWFuLm9yZy8xMDg1NjQyCkZvcndhcmRlZDogbm8KTGFzdC1VcGRhdGU6IDIwMjQtMTItMDMK Ci0tLSBhL2lsb3Jlc3QvZXh0ZW5zaW9ucy9pTE9fQ09NTUFORFMvRXRoZXJuZXRDb21tYW5kLnB5 CisrKyBiL2lsb3Jlc3QvZXh0ZW5zaW9ucy9pTE9fQ09NTUFORFMvRXRoZXJuZXRDb21tYW5kLnB5 CkBAIC01NzIsMTQgKzU3MiwxMiBAQAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgdHJ5OgogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIGRhdGFbZXRoX2NvbmZpZ190eXBlXVtfcGF0aF1bIkRIQ1B2NCJdWyJV c2VOVFBTZXJ2ZXJzIl0gPSBUcnVlCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgZGF0YVtldGhfY29uZmlnX3R5cGVdW19wYXRoXVsiREhDUHY2Il1b IlVzZU5UUFNlcnZlcnMiXSA9IFRydWUKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICBkYXRhW2V0aF9jb25maWdfdHlwZV1bX3BhdGhdWyJPZW0iXQot ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIFtzZWxm LnJkbWMuYXBwLnR5cGVwYXRoLmRlZnMub2VtaHBdWyJESENQdjQiXVsKLSAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIlVzZU5UUFNlcnZlcnMi Ci0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgXSA9 IFRydWUKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICBkYXRhW2V0aF9jb25maWdfdHlwZV1bX3BhdGhdWyJPZW0iXQotICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIFtzZWxmLnJkbWMuYXBwLnR5cGVwYXRo LmRlZnMub2VtaHBdWyJESENQdjYiXVsKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgIlVzZU5UUFNlcnZlcnMiCi0gICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgXSA9IFRydWUKKyAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBkYXRhW2V0aF9jb25maWdf dHlwZV1bX3BhdGhdWyJPZW0iXVtzZWxmLnJkbWMuYXBwLnR5cGVwYXRoLmRlZnMub2VtaHBdWwor ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAi REhDUHY0IgorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIF1bIlVzZU5UUFNlcnZlcnMiXSA9IFRydWUKKyAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICBkYXRhW2V0aF9jb25maWdfdHlwZV1bX3BhdGhdWyJP ZW0iXVtzZWxmLnJkbWMuYXBwLnR5cGVwYXRoLmRlZnMub2VtaHBdWworICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAiREhDUHY2IgorICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIF1bIlVzZU5UUFNl cnZlcnMiXSA9IFRydWUKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICBzZWxmLmxvYWRfZXRoZXJuZXRfYXV4KAogICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBldGhfY29uZmlnX3R5cGUsCiAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIF9wYXRo LAo=


    --=-R7CBFqdF5RKNLHv0cM1x--

    -----BEGIN PGP SIGNATURE-----

    iQJIBAABCgAyFiEEvu1N7VVEpMA+KD3HS80FZ8KW0F0FAmd4IF0UHGRsZWlkZXJ0 QGRlYmlhbi5vcmcACgkQS80FZ8KW0F00Lg/+IPAU7uQT8+c7VFeNMDHufJ5rXEgb kYWWUN5pgDJEg9FNT52Y0mlxjNTgJda6XkFiC9FJ+3IF6K6uem/is5ty1nbBwI6B tEjPJm+nlMFij/k4pYA2MRXMbfH4iKmUbUvMxg4AofCI8lW9bp4bLooFauOQGeVz +EZRSX1TcfLZbY6FxBVd3OoElY//TfubiEV3WwfmvYw5zX++XQBO4Ix3K/sFvXDd 9dDmy1Znym2qdEBJqyJ5UHL3+JorCYnmmAdNWvWRSnWut3ySqilnYbqNY/IhSwmc acbXG6f7RlFxXyzUTCop22bexk8F/FY9G4DyFBvMnSkDAhIjjgJ1h6hG5fsAUqor uM2LfG/P8tF5xht5ON03No+GTL+Zl+/QsEGmubFuQv4H9SdGtZrjzKXJVlWge+Ae yDpa0uP9r0N7lLiGeYEfqYS5Eo/3AyM26/tHQ8VcEt0hHTGhWIdH2oPywCIPCgdG Ql29YDrX9nCNmAnY5pGXXn8ZD+XE5MPOk2Jtdz/su0hzR+XnVLQWd1b2uVlYS+S/ hpm+656zUROgF3FvmQYusTLRNOjHERBF/IQZoTADH3jP0SLihUJURMNsybThDzhL A82nel22lDbLfPdEwEB460wKp1G2NZPKC96MeqyJ8+I/rEAwgCkfPcU2vCoarc6h 5Qfo8woqp8bplTU=
    =GyeL
    -----END PGP SIGNATURE-----

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)